Subject: Re: [PATCH net-next v2 01/10] net: libwx: Add irq flow functions

From: Jakub Kicinski <[email-masked]>
Date: Wed, 1 Feb 2023 21:45:05 -0800

On Tue, 31 Jan 2023 18:05:32 +0800 Mengyuan Lou wrote:
> +	/* initialize work limits */
> +	q_vector->tx.work_limit = wx->tx_work_limit;
> +	q_vector->rx.work_limit = wx->rx_work_limit;

How is the work limit used? 

> +	wx->isb_mem = dma_alloc_coherent(&pdev->dev,
> +					 sizeof(u32) * 4,
> +					 &wx->isb_dma,
> +					 GFP_KERNEL);
> +	if (!wx->isb_mem) {
> +		wx_err(wx, "Alloc isb_mem failed\n");
> +		return -ENOMEM;
> +	}
> +	memset(wx->isb_mem, 0, sizeof(u32) * 4);

unnecessary, dma_alloc_coherent() clears the memory.