Subject: Re: [PATCH net] net: page_pool: use in_softirq() instead

From: Jakub Kicinski <[email-masked]>
Date: Wed, 1 Feb 2023 22:01:05 -0800

On Thu,  2 Feb 2023 10:44:17 +0800 Qingfang DENG wrote:
> From: Qingfang DENG <[email-masked]>
> 
> We use BH context only for synchronization, so we don't care if it's
> actually serving softirq or not.
> 
> As a side node, in case of threaded NAPI, in_serving_softirq() will
> return false because it's in process context with BH off, making
> page_pool_recycle_in_cache() unreachable.

LGTM, but I don't think this qualifies as a fix.
It's just a missed optimization, right?