Subject: Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread_workqueue

From: Stanislaw Gruszka <[email-masked]>
Date: Wed, 8 Feb 2023 21:16:58 +0100

On Wed, Feb 08, 2023 at 02:30:31PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of the create_singlethread_workqueue
> in order to avoid NULL pointer dereference.
> 
> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
> Signed-off-by: Jiasheng Jiang <[email-masked]>
Acked-by: Stanislaw Gruszka <[email-masked]>

>  static void
> @@ -6618,7 +6622,11 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		goto out_disable_msi;
>  	}
>  
> -	il4965_setup_deferred_work(il);
> +	err = il4965_setup_deferred_work(il);
> +	if (err) {
> +		goto out_free_irq;
> +	}

{} not needded.