Subject: Re: [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query

From: Jakub Kicinski <[email-masked]>
Date: Thu, 9 Feb 2023 22:19:06 -0800

On Mon, 6 Feb 2023 15:54:35 +0200 Oz Shlomo wrote:
> +		for (k = 1; k < tcf_pedit_nkeys(act); k++) {
> +			last_cmd = cmd;
> +			cmd = tcf_pedit_cmd(act, k);
> +
> +			if (cmd != last_cmd) {
> +				NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
> +				return -EOPNOTSUPP;
> +			}

Is there a reason you're comparing to previous and not just always 
to the first one - since they all must be the same?