Subject: Re: [net-next 01/15] net/mlx5: Lag, Let user configure multiport eswitch

From: Jakub Kicinski <[email-masked]>
Date: Fri, 10 Feb 2023 20:03:29 -0800

On Fri, 10 Feb 2023 14:18:07 -0800 Saeed Mahameed wrote:
> From: Roi Dayan <[email-masked]>
> 
> Instead of activating multiport eswitch dynamically through
> adding a TC rule and meeting certain conditions, allow the user
> to activate it through devlink.
> This will remove the forced requirement of using TC.
> e.g. Bridge offload.
> 
> Example:
>     $ devlink dev param set pci/0000:00:0b.0 name esw_multiport value 1 \
>                   cmode runtime

The PR message has way better description of what's going on here.

> +   * - ``esw_multiport``
> +     - Boolean
> +     - runtime
> +     - Set the E-Switch lag mode to multiport.

This is just spelling out the name, not real documentation :(

IIUC the new mode is how devices _should_ work in switchdev mode,
so why not make this the default already? What's the cut-off point?