Subject: Re: [net 07/10] net/mlx5e: Correct SKB room check to use all room in the fifo

From: Jakub Kicinski <[email-masked]>
Date: Thu, 23 Feb 2023 16:38:36 -0800

On Thu, 23 Feb 2023 14:52:44 -0800 Saeed Mahameed wrote:
> From: Rahul Rameshbabu <[email-masked]>
> 
> Previous check was comparing against the fifo mask. The mask is size of the
> fifo (power of two) minus one, so a less than or equal comparator should be
> used for checking if the fifo has room for the SKB.
> 
> Fixes: 19b43a432e3e ("net/mlx5e: Extend SKB room check to include PTP-SQ")

How big is the fifo? Not utilizing a single entry is not really worth
calling a bug if the fifo has at least 32 entries..