Subject: Re: [PATCH] net: hsr: Don't log netdev_err message on unknown prp dst node

From: Jakub Kicinski <[email-masked]>
Date: Wed, 8 Mar 2023 23:20:01 -0800

On Tue,  7 Mar 2023 14:32:29 +0100 Kristian Overskeid wrote:
>  	if (!node_dst) {
> -		if (net_ratelimit())
> +		if (net_ratelimit() && port->hsr->prot_version != PRP_V1)

nit: wouldn't the condition make more sense before the net_ratelimit() ?
net_ratelimit() will update its state which is unnecessary if we're not
going to print either way.

When you repost - could you cast a wider net with the CC list?
Add the author of the code? (The print itself, not Taehee)
Maybe some folks who touched this file most recently?

>  			netdev_err(skb->dev, "%s: Unknown node\n", __func__);