Subject: Re: [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus()

From: Jakub Kicinski <[email-masked]>
Date: Thu, 9 Mar 2023 22:57:10 -0800

On Thu,  9 Mar 2023 20:42:31 +0300 Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking

True, but you need to tell the reader why you're making the change.
One of the impossible-to-hit error handling paths is missing unwind
or some such?