Subject: Re: [PATCH RFC v4 net-next 11/13] pds_core: add the aux client API

From: Leon Romanovsky <[email-masked]>
Date: Tue, 14 Mar 2023 14:14:52 +0200

On Tue, Mar 07, 2023 at 09:13:08PM -0800, Shannon Nelson wrote:
> Add the client API operations for registering, unregistering,
> and running adminq commands.  We expect to add additional
> operations for other clients, including requesting additional
> private adminqs and IRQs, but don't have the need yet,
> 
> Signed-off-by: Shannon Nelson <[email-masked]>
> ---
>  drivers/net/ethernet/amd/pds_core/auxbus.c | 134 ++++++++++++++++++++-
>  include/linux/pds/pds_auxbus.h             |  42 +++++++
>  2 files changed, 174 insertions(+), 2 deletions(-)

<...>

> +static struct pds_core_ops pds_core_ops = {
> +	.register_client = pds_client_register,
> +	.unregister_client = pds_client_unregister,
> +	.adminq_cmd = pds_client_adminq_cmd,
> +};

<...>

> +/*
> + *   ptrs to functions to be used by the client for core services
> + */
> +struct pds_core_ops {
> +	/* .register() - register the client with the device
> +	 * padev:  ptr to the client device info
> +	 * Register the client with the core and with the DSC.  The core
> +	 * will fill in the client padrv->client_id for use in calls
> +	 * to the DSC AdminQ
> +	 */
> +	int (*register_client)(struct pds_auxiliary_dev *padev);
> +
> +	/* .unregister() - disconnect the client from the device
> +	 * padev:  ptr to the client device info
> +	 * Disconnect the client from the core and with the DSC.
> +	 */
> +	int (*unregister_client)(struct pds_auxiliary_dev *padev);
> +
> +	/* .adminq_cmd() - process an adminq request for the client
> +	 * padev:  ptr to the client device
> +	 * req:     ptr to buffer with request
> +	 * req_len: length of actual struct used for request
> +	 * resp:    ptr to buffer where answer is to be copied
> +	 * flags:   optional flags defined by enum pds_core_adminq_flags
> +	 *	    and used for more flexible adminq behvior
> +	 *
> +	 * returns 0 on success, or
> +	 *         negative for error
> +	 * Client sends pointers to request and response buffers
> +	 * Core copies request data into pds_core_client_request_cmd
> +	 * Core sets other fields as needed
> +	 * Core posts to AdminQ
> +	 * Core copies completion data into response buffer
> +	 */
> +	int (*adminq_cmd)(struct pds_auxiliary_dev *padev,
> +			  union pds_core_adminq_cmd *req,
> +			  size_t req_len,
> +			  union pds_core_adminq_comp *resp,
> +			  u64 flags);
> +};

I don't expect to see any register/unregister AUX client code at all.

All clients are registered and unregistered through
auxiliary_driver_register()/auxiliary_driver_unregister() calls and
perform as standalone drivers.

Maybe client, register and unregister words means something else in this
series..

Thanks

>  #endif /* _PDSC_AUXBUS_H_ */
> -- 
> 2.17.1
>