Subject: Re: [PATCH net v2 1/4] bonding: add bond_ether_setup helper

From: Jakub Kicinski <[email-masked]>
Date: Wed, 15 Mar 2023 00:55:57 -0700

On Tue, 14 Mar 2023 13:14:23 +0200 Nikolay Aleksandrov wrote:
> +/* ether_setup() resets bond_dev's flags so we always have to restore
> + * IFF_MASTER, and only restore IFF_SLAVE if it was set
> + */
> +static void bond_ether_setup(struct net_device *bond_dev)
> +{
> +	unsigned int slave_flag = bond_dev->flags & IFF_SLAVE;
> +
> +	ether_setup(bond_dev);
> +	bond_dev->flags |= IFF_MASTER | slave_flag;
> +	bond_dev->priv_flags &= ~IFF_TX_SKB_SHARING;
> +}
> +

We can't split this from patch 2, it's going to generate a warning
under normal build flags, people may have WERROR set these days..