From: Rob Herring <robh@kernel•org>
To: Arnd Bergmann <arnd@kernel•org>
Cc: "Christian Lamparter" <chunkeey@googlemail•com>,
"Kalle Valo" <kvalo@kernel•org>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Bartosz Golaszewski" <brgl@bgdev•pl>,
linux-gpio@vger•kernel.org, linux-omap@vger•kernel.org,
"Tony Lindgren" <tony@atomide•com>,
"Aaro Koskinen" <aaro.koskinen@iki•fi>,
"Felipe Balbi" <balbi@kernel•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Benoît Cousson" <bcousson@baylibre•com>,
"Russell King" <linux@armlinux•org.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail•com>,
"Johannes Berg" <johannes@sipsolutions•net>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
Date: Fri, 17 Mar 2023 16:16:21 -0500 [thread overview]
Message-ID: <20230317211621.GA2814846-robh@kernel.org> (raw)
In-Reply-To: <20230314163201.955689-1-arnd@kernel.org>
On Tue, Mar 14, 2023 at 05:30:56PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb•de>
>
> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
> pass them as module parameters, apparently a relic from its life as a
> staging driver. This works because there is only one user, the Nokia
> N8x0 tablet.
>
> Convert this to the gpio descriptor interface and move the gpio
> line information into devicetree to improve this and simplify the
> code at the same time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> ---
> As I don't have an N8x0, this is completely untested.
>
> I listed the driver authors (Johannes and Christian) as the maintainers
> of the binding document, but I don't know if they actually have this
> hardware. It might be better to list someone who is actually using it.
>
> Among the various chip identifications, I wasn't sure which one to
> use for the compatible string and the name of the binding document.
> I picked st,stlc4560 as that was cited as the version in the N800
> on multiple websites.
> ---
> .../bindings/net/wireless/st,stlc45xx.yaml | 64 +++++++++++++++++
> MAINTAINERS | 1 +
> arch/arm/boot/dts/omap2.dtsi | 4 ++
> arch/arm/boot/dts/omap2420-n8x0-common.dtsi | 12 ++++
> arch/arm/mach-omap2/board-n8x0.c | 18 -----
> drivers/net/wireless/intersil/p54/p54spi.c | 69 +++++++------------
> drivers/net/wireless/intersil/p54/p54spi.h | 3 +
> 7 files changed, 109 insertions(+), 62 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml
Binding looks fine, but I assume you'll split this into at least 3
patches?
Rob
prev parent reply other threads:[~2023-03-17 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:30 [PATCH] p54spi: convert to devicetree Arnd Bergmann
2023-03-14 16:44 ` Johannes Berg
2023-03-14 19:57 ` Krzysztof Kozlowski
2023-03-14 21:40 ` Arnd Bergmann
2023-03-15 6:32 ` Krzysztof Kozlowski
2023-03-15 6:50 ` Arnd Bergmann
2023-03-15 7:11 ` Krzysztof Kozlowski
2023-03-14 20:18 ` Christian Lamparter
2023-03-15 5:32 ` Kalle Valo
2023-03-17 21:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317211621.GA2814846-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=aaro.koskinen@iki$(echo .)fi \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=balbi@kernel$(echo .)org \
--cc=bcousson@baylibre$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=chunkeey@googlemail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox