Subject: Re: [PATCH v7 net-next 1/7] netlink: Add a macro to set policy message with format string

From: Jakub Kicinski <[email-masked]>
Date: Thu, 23 Mar 2023 10:29:06 -0700

On Thu, 23 Mar 2023 18:36:04 +0200 Shay Agroskin wrote:
> +#define NL_SET_ERR_MSG_ATTR_POL_FMT(extack, attr, pol, fmt, args...) do {	\
> +	struct netlink_ext_ack *__extack = (extack);				\
> +										\
> +	if (!__extack)								\
> +		break;								\
> +										\
> +	if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN,		\
> +		     "%s" fmt "%s", "", ##args, "") >=				\
> +	    NETLINK_MAX_FMTMSG_LEN)						\
> +		net_warn_ratelimited("%s" fmt "%s", "truncated extack: ",       \
> +				     ##args, "\n");				\
> +										\
> +	do_trace_netlink_extack(__extack->_msg_buf);				\
> +										\
> +	__extack->_msg = __extack->_msg_buf;					\
> +	__extack->bad_attr = (attr);						\
> +	__extack->policy = (pol);						\
> +} while (0)

Given the misunderstanding let me give you an exception to the 24h 
wait period. Feel free to send v8 when ready, I'll drop this version 
from pw.