Subject: Re: [PATCH net-next v2 4/4] tools: ynl: ethtool testing tool

From: Jakub Kicinski <[email-masked]>
Date: Fri, 24 Mar 2023 20:35:43 -0700

On Fri, 24 Mar 2023 15:56:56 -0700 Stanislav Fomichev wrote:
> +def args_to_req(ynl, op_name, args, req):
> +  """
> +  Verify and convert command-line arguments to the ynl-compatible request.
> +  """
> +  valid_attrs = ynl.operation_do_attributes(op_name)
> +  valid_attrs.remove('header') # not user-provided
> +
> +  if len(args) == 0:
> +    print(f'no attributes, expected: {valid_attrs}')
> +    sys.exit(1)

Could you re-format with 4 char indentation? To keep it consistent with
the rest of ynl?