From: Jakub Kicinski <kuba@kernel•org>
To: Emeel Hakim <ehakim@nvidia•com>
Cc: "davem@davemloft•net" <davem@davemloft•net>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"edumazet@google•com" <edumazet@google•com>,
"sd@queasysnail•net" <sd@queasysnail•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 1/4] vlan: Add MACsec offload operations for VLAN interface
Date: Tue, 28 Mar 2023 15:41:54 -0700 [thread overview]
Message-ID: <20230328154154.14bbee54@kernel.org> (raw)
In-Reply-To: <IA1PR12MB6353B5E1BC80B60993267190AB889@IA1PR12MB6353.namprd12.prod.outlook.com>
On Tue, 28 Mar 2023 06:54:11 +0000 Emeel Hakim wrote:
> > > + if (real_dev->features & NETIF_F_HW_MACSEC)
> > > + features |= NETIF_F_HW_MACSEC;
> > > +
> > > return features;
> > > }
> >
> > Shouldn't vlan_features be consulted somehow?
>
> I did consider including the vlan_features, but after careful
> consideration, I couldn't see how they were relevant to the task at
> hand.
Decode this for me please:
- what was you careful consideration
- what do you think the task at hand is; and
- what are vlan_features supposed to mean?
next prev parent reply other threads:[~2023-03-28 22:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 7:26 [PATCH net-next 0/4] Support MACsec VLAN Emeel Hakim
2023-03-26 7:26 ` [PATCH net-next 1/4] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-03-27 16:43 ` Jakub Kicinski
2023-03-28 6:54 ` Emeel Hakim
2023-03-28 18:20 ` Francois Romieu
2023-03-29 11:07 ` Emeel Hakim
2023-03-28 22:41 ` Jakub Kicinski [this message]
2023-03-29 11:08 ` Emeel Hakim
2023-03-26 7:26 ` [PATCH net-next 2/4] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-03-26 7:26 ` [PATCH net-next 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-03-26 7:26 ` [PATCH net-next 4/4] macsec: Add MACsec rx_handler change support Emeel Hakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328154154.14bbee54@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=ehakim@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox