Subject: Re: [net-next v9 5/6] net: stmmac: Add glue layer for StarFive JH7110 SoC

From: Jakub Kicinski <[email-masked]>
Date: Tue, 28 Mar 2023 19:17:16 -0700

On Tue, 28 Mar 2023 14:20:08 +0800 Samin Guo wrote:
> This adds StarFive dwmac driver support on the StarFive JH7110 SoC.
> 
> Tested-by: Tommaso Merciai <[email-masked]>
> Co-developed-by: Emil Renner Berthing <[email-masked]>
> Signed-off-by: Emil Renner Berthing <[email-masked]>
> Signed-off-by: Samin Guo <[email-masked]>

Excellent, now it applies cleanly :)

Our clang build with W=1 complains that:

drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c:37:2: warning: variable 'rate' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
        default:
        ^~~~~~~
drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c:42:36: note: uninitialized use occurs here
        err = clk_set_rate(dwmac->clk_tx, rate);
                                          ^~~~
drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c:24:20: note: initialize the variable 'rate' to silence this warning
        unsigned long rate;
                          ^
                           = 0

not sure how you prefer to fix this. Maybe return early?