Subject: Re: [PATCH 1/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover()

From: Leon Romanovsky <[email-masked]>
Date: Wed, 29 Mar 2023 13:31:58 +0300

On Fri, Mar 24, 2023 at 10:55:40AM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
> 
> drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c:104 mlx5e_rx_reporter_err_icosq_cqe_recover() warn: missing error code 'err'.
> 
> Reported-by: Abaci Robot <[email-masked]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4601
> Signed-off-by: Jiapeng Chong <[email-masked]>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> index b621f735cdc3..b66183204be3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> @@ -100,8 +100,10 @@ static int mlx5e_rx_reporter_err_icosq_cqe_recover(void *ctx)
>  		goto out;
>  	}
>  
> -	if (state != MLX5_SQC_STATE_ERR)
> +	if (state != MLX5_SQC_STATE_ERR) {
> +		err = -EINVAL;

I'm not sure about correctness of this change. SQC is not in error
state, there is nothing to recover here.

Thanks

>  		goto out;
> +	}
>  	mlx5e_deactivate_rq(rq);
>  	if (xskrq)
> -- 
> 2.20.1.7.g153144c