From: Jakub Kicinski <kuba@kernel•org>
To: Jason Xing <kerneljasonxing@gmail•com>
Cc: jbrouer@redhat•com, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, ast@kernel•org, daniel@iogearbox•net,
hawk@kernel•org, john.fastabend@gmail•com,
stephen@networkplumber•org, simon.horman@corigine•com,
sinquersw@gmail•com, bpf@vger•kernel.org, netdev@vger•kernel.org,
Jason Xing <kernelxing@tencent•com>
Subject: Re: [PATCH v4 net-next 2/2] net: introduce budget_squeeze to help us tune rx behavior
Date: Thu, 30 Mar 2023 19:20:50 -0700 [thread overview]
Message-ID: <20230330192050.1e057776@kernel.org> (raw)
In-Reply-To: <CAL+tcoBKiVqETEAPPawLbS_OF0Eb6HgZRHe-=W81bVKCkpr4Rg@mail.gmail.com>
On Fri, 31 Mar 2023 08:48:07 +0800 Jason Xing wrote:
> On Fri, Mar 31, 2023 at 12:23 AM Jakub Kicinski <kuba@kernel•org> wrote:
> > On Thu, 30 Mar 2023 17:59:46 +0800 Jason Xing wrote:
> > > I'm wondering for now if I can update and resend this patch to have a
> > > better monitor (actually we do need one) on this part since we have
> > > touched the net_rx_action() in the rps optimization patch series?
> > > Also, just like Jesper mentioned before, it can be considered as one
> > > 'fix' to a old problem but targetting to net-next is just fine. What
> > > do you think about it ?
> >
> > Sorry, I don't understand what you're trying to say :(
>
> Previously this patch was not accepted because we do not want to touch
> softirqs (actually which is net_rx_action()). Since it is touched in
> the commit [1] in recent days, I would like to ask your permission:
> could I resend this patch to the mailing list? I hope we can get it
> merged.
>
> This patch can be considered as a 'fix' to the old problem. It's
> beneficial and harmless, I think :)
The not touching part was about softirqs which is kernel/softirq.c,
this patch was rejected because it's not useful.
next prev parent reply other threads:[~2023-03-31 2:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 9:20 [PATCH v4 net-next 0/2] add some detailed data when reading softnet_stat Jason Xing
2023-03-15 9:20 ` [PATCH v4 net-next 1/2] net-sysfs: display two backlog queue len separately Jason Xing
2023-03-19 3:05 ` Jason Xing
2023-03-20 18:40 ` Jakub Kicinski
2023-03-21 1:49 ` Jason Xing
2023-03-15 9:20 ` [PATCH v4 net-next 2/2] net: introduce budget_squeeze to help us tune rx behavior Jason Xing
2023-03-17 0:20 ` Jakub Kicinski
2023-03-17 2:27 ` Jason Xing
2023-03-17 3:26 ` Jakub Kicinski
2023-03-17 4:11 ` Jason Xing
2023-03-17 4:30 ` Jakub Kicinski
2023-03-18 4:00 ` Jason Xing
2023-03-20 13:30 ` Jesper Dangaard Brouer
2023-03-20 18:46 ` Jakub Kicinski
2023-03-21 2:08 ` Jason Xing
2023-03-30 9:59 ` Jason Xing
2023-03-30 16:23 ` Jakub Kicinski
2023-03-31 0:48 ` Jason Xing
2023-03-31 2:20 ` Jakub Kicinski [this message]
2023-03-31 2:33 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330192050.1e057776@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jbrouer@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kerneljasonxing@gmail$(echo .)com \
--cc=kernelxing@tencent$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=sinquersw@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox