Subject: Re: [PATCH v8 net-next 05/14] pds_core: set up device and adminq

From: Jakub Kicinski <[email-masked]>
Date: Fri, 31 Mar 2023 22:07:19 -0700

On Thu, 30 Mar 2023 16:46:19 -0700 Shannon Nelson wrote:
> +	listlen = fw_list.num_fw_slots;
> +	for (i = 0; i < listlen; i++) {
> +		snprintf(buf, sizeof(buf), "fw.%s",
> +			 fw_list.fw_names[i].slotname);
> +		err = devlink_info_version_stored_put(req, buf,
> +						      fw_list.fw_names[i].fw_version);
> +	}

Keys must be enumerated in the kernel, no copying directly from 
the FW please.

Also it'd be a little easier to review if the documentation was part 
of the same patch as code :(