From: kernel test robot <lkp@intel•com>
To: "Jesper Dangaard Brouer" <brouer@redhat•com>,
bpf@vger•kernel.org, "Stanislav Fomichev" <sdf@google•com>,
"Toke Høiland-Jørgensen" <toke@redhat•com>
Cc: oe-kbuild-all@lists•linux.dev,
Jesper Dangaard Brouer <brouer@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
martin.lau@kernel•org, ast@kernel•org, daniel@iogearbox•net,
alexandr.lobakin@intel•com, larysa.zaremba@intel•com,
xdp-hints@xdp-project•net, anthony.l.nguyen@intel•com,
yoong.siang.song@intel•com, boon.leong.ong@intel•com,
intel-wired-lan@lists•osuosl.org, pabeni@redhat•com,
jesse.brandeburg@intel•com, kuba@kernel•org, edumazet@google•com,
john.fastabend@gmail•com, hawk@kernel•org, davem@davemloft•net,
tariqt@nvidia•com
Subject: Re: [PATCH bpf V4 1/5] xdp: rss hash types representation
Date: Sat, 1 Apr 2023 02:23:03 +0800 [thread overview]
Message-ID: <202304010239.Jw6bKkWC-lkp@intel.com> (raw)
In-Reply-To: <168027498690.3941176.99100635661990098.stgit@firesoul>
Hi Jesper,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf/master]
url: https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/xdp-rss-hash-types-representation/20230331-230552
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
patch link: https://lore.kernel.org/r/168027498690.3941176.99100635661990098.stgit%40firesoul
patch subject: [PATCH bpf V4 1/5] xdp: rss hash types representation
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230401/202304010239.Jw6bKkWC-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/9fcbbefa76e6e88a86426d13ed79ea24aacffe76
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jesper-Dangaard-Brouer/xdp-rss-hash-types-representation/20230331-230552
git checkout 9fcbbefa76e6e88a86426d13ed79ea24aacffe76
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel•com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304010239.Jw6bKkWC-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/veth.c:1685:43: error: initialization of 'int (*)(const struct xdp_md *, u32 *, enum xdp_rss_hash_type *)' {aka 'int (*)(const struct xdp_md *, unsigned int *, enum xdp_rss_hash_type *)'} from incompatible pointer type 'int (*)(const struct xdp_md *, u32 *)' {aka 'int (*)(const struct xdp_md *, unsigned int *)'} [-Werror=incompatible-pointer-types]
1685 | .xmo_rx_hash = veth_xdp_rx_hash,
| ^~~~~~~~~~~~~~~~
drivers/net/veth.c:1685:43: note: (near initialization for 'veth_xdp_metadata_ops.xmo_rx_hash')
cc1: some warnings being treated as errors
vim +1685 drivers/net/veth.c
4456e7bdf74c9f Stephen Hemminger 2008-11-19 1682
306531f0249f4e Stanislav Fomichev 2023-01-19 1683 static const struct xdp_metadata_ops veth_xdp_metadata_ops = {
306531f0249f4e Stanislav Fomichev 2023-01-19 1684 .xmo_rx_timestamp = veth_xdp_rx_timestamp,
306531f0249f4e Stanislav Fomichev 2023-01-19 @1685 .xmo_rx_hash = veth_xdp_rx_hash,
306531f0249f4e Stanislav Fomichev 2023-01-19 1686 };
306531f0249f4e Stanislav Fomichev 2023-01-19 1687
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-31 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 15:03 [PATCH bpf V4 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
2023-03-31 15:03 ` [PATCH bpf V4 1/5] xdp: rss hash types representation Jesper Dangaard Brouer
2023-03-31 18:23 ` kernel test robot [this message]
2023-03-31 19:12 ` Jesper Dangaard Brouer
2023-03-31 15:03 ` [PATCH bpf V4 2/5] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer
2023-03-31 15:03 ` [PATCH bpf V4 3/5] veth: " Jesper Dangaard Brouer
2023-03-31 15:03 ` [PATCH bpf V4 4/5] mlx4: " Jesper Dangaard Brouer
2023-03-31 15:03 ` [PATCH bpf V4 5/5] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer
2023-03-31 16:30 ` [PATCH bpf V4 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304010239.Jw6bKkWC-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=alexandr.lobakin@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=larysa.zaremba@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=martin.lau@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=xdp-hints@xdp-project$(echo .)net \
--cc=yoong.siang.song@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox