Subject: Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Apr 2023 14:19:18 -0700

On Mon, 3 Apr 2023 15:26:22 +0300 Vladimir Oltean wrote:
> > @@ -7365,6 +7364,8 @@ static const struct net_device_ops e1000e_netdev_ops = {
> >  	.ndo_set_features = e1000_set_features,
> >  	.ndo_fix_features = e1000_fix_features,
> >  	.ndo_features_check	= passthru_features_check,
> > +	.ndo_hwtstamp_get	= e1000e_hwtstamp_get,
> > +	.ndo_hwtstamp_set	= e1000e_hwtstamp_set,
> >  };  
> 
> The conversion per se looks almost in line with what I was expecting to
> see, except for the comments. I guess you can convert a single driver
> first (e1000 seems fine), to get the API merged, then more people could
> work in parallel?
> 
> Or do you want netdevsim to cover hardware timestamping from the
> beginning too, Jakub?

I'd vote to split netdevsim out, and it needs a selftest which
exercises it under tools/testing/selftests/drivers/net/netdevsim/
to get merged...