Subject: Re: [RFC PATCH net-next 3/6] net: ethtool: let the core choose RSS context IDs

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Apr 2023 14:54:06 -0700

On Mon, 3 Apr 2023 17:33:00 +0100 [email-masked] wrote:
>  	int	(*set_rxfh_context)(struct net_device *, const u32 *indir,
>  				    const u8 *key, const u8 hfunc,
> -				    u32 *rss_context, bool delete);
> +				    u32 rss_context, bool delete);

Would it be easier to pass struct ethtool_rxfh_context instead of
doing it field by field?  Otherwise Intel will need to add more
arguments and touch all drivers. Or are you thinking that they should
use a separate callback for the "RR RSS" or whatever their thing is?

And maybe separate op for create / change / delete?

And an extack on top... :)