Subject: Re: [PATCH v9 net-next 02/14] pds_core: add devcmd device interfaces

From: Jakub Kicinski <[email-masked]>
Date: Thu, 13 Apr 2023 08:08:58 -0700

On Thu, 13 Apr 2023 11:33:25 +0300 Leon Romanovsky wrote:
> > > This is only relevant here, everything else is not applicable.
> > >   
> > > > +     PDS_DRIVER_WIN     = 2,
> > > > +     PDS_DRIVER_DPDK    = 3,
> > > > +     PDS_DRIVER_FREEBSD = 4,
> > > > +     PDS_DRIVER_IPXE    = 5,
> > > > +     PDS_DRIVER_ESXI    = 6,
> > > > +};  
> > 
> > Yes, they are rather pointless for the Linux kernel, but it is part of
> > documenting the device interface.  
> 
> It is not used in upstream kernel.

If Shannon prefers to keep the full enum, I think that's fine.
Declaring the full interface is often the only way a user can
try to figure out how the API works, as most vendors don't publish
their APIs.