From: Leon Romanovsky <leon@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Haiyang Zhang <haiyangz@microsoft•com>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Dexuan Cui <decui@microsoft•com>,
KY Srinivasan <kys@microsoft•com>,
Paul Rosswurm <paulros@microsoft•com>,
"olaf@aepfle•de" <olaf@aepfle•de>,
"vkuznets@redhat•com" <vkuznets@redhat•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
"edumazet@google•com" <edumazet@google•com>,
"pabeni@redhat•com" <pabeni@redhat•com>,
Long Li <longli@microsoft•com>,
"ssengar@linux•microsoft.com" <ssengar@linux•microsoft.com>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"daniel@iogearbox•net" <daniel@iogearbox•net>,
"john.fastabend@gmail•com" <john.fastabend@gmail•com>,
"bpf@vger•kernel.org" <bpf@vger•kernel.org>,
"ast@kernel•org" <ast@kernel•org>,
Ajay Sharma <sharmaajay@microsoft•com>,
"hawk@kernel•org" <hawk@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU
Date: Thu, 13 Apr 2023 19:59:29 +0300 [thread overview]
Message-ID: <20230413165929.GU17993@unreal> (raw)
In-Reply-To: <20230413094003.3fa4cd8c@kernel.org>
On Thu, Apr 13, 2023 at 09:40:03AM -0700, Jakub Kicinski wrote:
> On Thu, 13 Apr 2023 19:30:59 +0300 Leon Romanovsky wrote:
> > > So the page pool is optimized for the XDP, and that sentence is applicable to drivers
> > > that have set up page pool for XDP optimization.
> >
> > "but it can fallback on the regular page allocator APIs."
>
> The XDP thing is historic AFAIU, page_pool has been expanded to cover
> all uses cases, and is "just better" (tm) than using page allocator
> directly. Maybe we should update the doc.
The last sentence is always true :)
next prev parent reply other threads:[~2023-04-13 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 21:15 [PATCH V3,net-next, 0/4] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 1/4] net: mana: Use napi_build_skb in RX path Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Haiyang Zhang
2023-04-13 13:04 ` Leon Romanovsky
2023-04-13 14:03 ` Haiyang Zhang
2023-04-13 16:30 ` Leon Romanovsky
2023-04-13 16:40 ` Jakub Kicinski
2023-04-13 16:59 ` Leon Romanovsky [this message]
2023-04-13 17:01 ` Jakub Kicinski
2023-04-15 2:04 ` Jakub Kicinski
2023-04-15 14:09 ` Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 3/4] net: mana: Enable RX path to handle various MTU sizes Haiyang Zhang
2023-04-15 2:06 ` Jakub Kicinski
2023-04-15 14:25 ` Haiyang Zhang
2023-04-17 17:52 ` Jakub Kicinski
2023-04-17 19:52 ` Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 4/4] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-15 2:08 ` [PATCH V3,net-next, 0/4] " Jakub Kicinski
2023-04-15 14:11 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413165929.GU17993@unreal \
--to=leon@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=sharmaajay@microsoft$(echo .)com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox