Subject: Re: [PATCH net-next 5/5] net: skbuff: hide nf_trace and ipvs_property

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Apr 2023 15:07:58 -0700

On Fri, 14 Apr 2023 23:09:50 +0200 Florian Westphal wrote:
> > +#if IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TRACE) || defined(CONFIG_NF_TABLES)
> >  	__u8			nf_trace:1;  
> 
> As already pointed out nftables can be a module, other than that

I copied it from:

static inline void nf_reset_trace(struct sk_buff *skb)
{
#if IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TRACE) || defined(CONFIG_NF_TABLES)
	skb->nf_trace = 0;
#endif
}

I can't quite figure out why this would be intentional.
Do the existing conditions need to be fixed? 🤔️