Subject: Re: [PATCH net-next 2/3] r8169: use new macro netif_subqueue_maybe_stop in rtl8169_start_xmit

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Apr 2023 18:53:29 -0700

On Thu, 13 Apr 2023 21:15:37 +0200 Heiner Kallweit wrote:
> +	stop_queue = netif_subqueue_maybe_stop(dev, 0, rtl_tx_slots_avail(tp),
> +					       R8169_TX_STOP_THRS,
> +					       R8169_TX_START_THRS);
> +	if (door_bell || stop_queue < 0)

Macro returns 0 if it did the action. So I'd have expected <= or !
Maybe better to invert the return value at the call site..

	stopped = !netif_subqueue_maybe_stop(...
	if (door_bell || stopped)
		..