Subject: Re: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN

From: Jakub Kicinski <[email-masked]>
Date: Tue, 18 Apr 2023 17:36:03 -0700

On Tue, 18 Apr 2023 11:31:00 +0300 Emeel Hakim wrote:
> +static inline struct mlx5e_priv *macsec_netdev_priv(const struct net_device *dev)

Does the compiler really not inline this without the explicit inline
keyword?

> +{
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)

That's what IS_ENABLED() is for

> +	if (is_vlan_dev(dev))
> +		return netdev_priv(vlan_dev_priv(dev)->real_dev);
> +#endif
> +	return netdev_priv(dev);
> +}

--
pw-bot: cr