Subject: Re: [PATCH net-next] gve: Add modify ring size support

From: Jakub Kicinski <[email-masked]>
Date: Wed, 19 Apr 2023 15:48:50 -0700

On Tue, 18 Apr 2023 22:13:13 +0000 Alex Berliner wrote:
> +		err = gve_close(priv->dev);
> +		if (err)
> +			return err;
> +		priv->tx_desc_cnt = new_tx_desc_cnt;
> +		priv->rx_desc_cnt = new_rx_desc_cnt;
> +
> +		err = gve_open(priv->dev);
> +		if (err)
> +			goto err;

please don't close / open. if the machine is low on memory it will 
fall off the network. I think I had a similar complaint about xdp
patches for gve, it'd be great if people working on gve within google
talked to each other.