From: Jakub Kicinski <kuba@kernel•org>
To: Pedro Tammela <pctammela@mojatatu•com>
Cc: netdev@vger•kernel.org, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, jiri@resnulli•us, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com
Subject: Re: [PATCH net-next v2 1/4] net/sched: sch_htb: use extack on errors messages
Date: Thu, 20 Apr 2023 07:17:28 -0700 [thread overview]
Message-ID: <20230420071728.42258044@kernel.org> (raw)
In-Reply-To: <d45983a3-6884-d8e9-499e-c9e71c4685d5@mojatatu.com>
On Wed, 19 Apr 2023 23:14:54 -0300 Pedro Tammela wrote:
> > I missed the message changes on v1, but since the patches are already
> > Changes Requested in patchwork...
> >
> > IDK what TC_HTB_LEAF_TO_INNER is exactly, neither do I understand
> > "Failed to offload leaf to inner". The first one should be "Failed to
> > alloc offload leaf queue" if anything.
> >
> > Let's just stick to the existing messages?
>
> The existing messages omit that the offload operation failed, which I
> think it would be important to say in these two cases.
> But taking a second look, the driver gets the extack so it should be up
> to the driver to provide the appropriate context when the offload fails.
> What do you think about demoting these messages to WEAK and change them
> to something like:
> "Failed to offload %attribute"
Good idea!
next prev parent reply other threads:[~2023-04-20 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 17:12 [PATCH net-next v2 0/4] net/sched: cleanup parsing prints in htb and qfq Pedro Tammela
2023-04-17 17:12 ` [PATCH net-next v2 1/4] net/sched: sch_htb: use extack on errors messages Pedro Tammela
2023-04-19 12:51 ` Simon Horman
2023-04-20 1:08 ` Jakub Kicinski
2023-04-20 2:14 ` Pedro Tammela
2023-04-20 14:17 ` Jakub Kicinski [this message]
2023-04-17 17:12 ` [PATCH net-next v2 2/4] net/sched: sch_qfq: " Pedro Tammela
2023-04-17 21:33 ` Jamal Hadi Salim
2023-04-19 12:52 ` Simon Horman
2023-04-17 17:12 ` [PATCH net-next v2 3/4] net/sched: sch_qfq: refactor parsing of netlink parameters Pedro Tammela
2023-04-19 12:53 ` Simon Horman
2023-04-17 17:12 ` [PATCH net-next v2 4/4] selftests: tc-testing: add more tests for sch_qfq Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420071728.42258044@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox