Subject: Re: [Intel-wired-lan] [PATCH net-next] iavf: remove double underscores from states names

From: Jakub Kicinski <[email-masked]>
Date: Thu, 20 Apr 2023 07:59:43 -0700

On Thu, 20 Apr 2023 16:33:54 +0200 Alexander Lobakin wrote:
> > No need to prepend some states names with "__", especially that others do
> > not have these underscores.  
> 
> What's the value of this change, apart from 400 locs diffstat? I don't
> say having prefixes for general-purpose definitions is correct, but...
> Dunno. Would be nice to have as a part of some series with assorted
> improvements, but not standalone. Or it's just me =\

Yeah, I'm not sure it's bad enough to justify the code churn, either.
Up to you folks at Intel.