From: Hangbin Liu <liuhangbin@gmail•com>
To: netdev@vger•kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>, Liang Li <liali@redhat•com>,
Vincent Bernat <vincent@bernat•ch>,
Hangbin Liu <liuhangbin@gmail•com>
Subject: [PATCH net 0/4] bonding: fix send_peer_notif overflow
Date: Thu, 20 Apr 2023 16:22:26 +0800 [thread overview]
Message-ID: <20230420082230.2968883-1-liuhangbin@gmail.com> (raw)
Bonding send_peer_notif was defined as u8. But the value is
num_peer_notif multiplied by peer_notif_delay, which is u8 * u32.
This would cause the send_peer_notif overflow.
Before the fix:
TEST: num_grat_arp (active-backup miimon num_grat_arp 10) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 20) [ OK ]
4 garp packets sent on active slave eth1
TEST: num_grat_arp (active-backup miimon num_grat_arp 30) [FAIL]
24 garp packets sent on active slave eth1
TEST: num_grat_arp (active-backup miimon num_grat_arp 50) [FAIL]
After the fix:
TEST: num_grat_arp (active-backup miimon num_grat_arp 10) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 20) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 30) [ OK ]
TEST: num_grat_arp (active-backup miimon num_grat_arp 50) [ OK ]
Hangbin Liu (4):
bonding: fix send_peer_notif overflow
Documentation: bonding: fix the doc of peer_notif_delay
selftests: forwarding: lib: add netns support for tc rule handle stats
get
kselftest: bonding: add num_grat_arp test
Documentation/networking/bonding.rst | 7 ++-
include/net/bonding.h | 2 +-
.../drivers/net/bonding/bond_options.sh | 50 +++++++++++++++++++
.../drivers/net/bonding/bond_topo_3d1c.sh | 2 +
tools/testing/selftests/net/forwarding/lib.sh | 3 +-
5 files changed, 58 insertions(+), 6 deletions(-)
--
2.38.1
next reply other threads:[~2023-04-20 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:22 Hangbin Liu [this message]
2023-04-20 8:22 ` [PATCH net 1/4] bonding: fix send_peer_notif overflow Hangbin Liu
2023-04-20 14:34 ` kernel test robot
2023-04-20 15:59 ` Jay Vosburgh
2023-04-20 23:21 ` Jakub Kicinski
2023-04-21 3:42 ` Hangbin Liu
2023-04-21 5:13 ` Jay Vosburgh
2023-04-21 9:55 ` Hangbin Liu
2023-04-26 7:03 ` Hangbin Liu
2023-04-26 21:15 ` Jay Vosburgh
2023-04-20 8:22 ` [PATCH net 2/4] Documentation: bonding: fix the doc of peer_notif_delay Hangbin Liu
2023-04-20 15:52 ` Jay Vosburgh
2023-04-20 8:22 ` [PATCH net 3/4] selftests: forwarding: lib: add netns support for tc rule handle stats get Hangbin Liu
2023-04-20 8:22 ` [PATCH net 4/4] kselftest: bonding: add num_grat_arp test Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420082230.2968883-1-liuhangbin@gmail.com \
--to=liuhangbin@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liali@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vincent@bernat$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox