From: Vladimir Oltean <vladimir.oltean@nxp•com>
To: Simon Horman <simon.horman@corigine•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Michal Kubecek <mkubecek@suse•cz>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp•com>,
Petr Machata <petrm@nvidia•com>,
Danielle Ratson <danieller@nvidia•com>,
Pranavi Somisetty <pranavi.somisetty@amd•com>,
Harini Katakam <harini.katakam@amd•com>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>,
Kurt Kanzenbach <kurt@linutronix•de>,
Gerhard Engleder <gerhard@engleder-embedded•com>,
Ferenc Fejes <ferenc.fejes@ericsson•com>,
Aaron Conole <aconole@redhat•com>,
linux-kselftest@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 net-next 1/9] net: enetc: fix MAC Merge layer remaining enabled until a link down event
Date: Thu, 20 Apr 2023 20:03:54 +0300 [thread overview]
Message-ID: <20230420170354.n76b53ws6bitcoj2@skbuf> (raw)
In-Reply-To: <ZEFKjPR/VL6llxDm@corigine.com>
On Thu, Apr 20, 2023 at 04:22:04PM +0200, Simon Horman wrote:
> > - /* If link is up, enable MAC Merge right away */
> > - if (!!(priv->active_offloads & ENETC_F_QBU) &&
> > - !(val & ENETC_MMCSR_LINK_FAIL))
> > - val |= ENETC_MMCSR_ME;
> > + /* If link is up, enable/disable MAC Merge right away */
> > + if (!(val & ENETC_MMCSR_LINK_FAIL)) {
> > + if (!!(priv->active_offloads & ENETC_F_QBU))
>
> nit: The !!() seems unnecessary,
> I wonder if it can be written in a simpler way as:
>
> if (priv->active_offloads & ENETC_F_QBU)
I agree. Normally I omit the double negation in simple statements like this.
Here I didn't, because the expression was split into 2 "if" conditions,
and I kept the individual terms as-is for some reason.
Since the generated object code is absolutely the same either way, I would not
resend just for minor style comments such as this one, if you don't mind.
However, I do appreciate the review and I'll pay more attention to this
detail in the future.
next prev parent reply other threads:[~2023-04-20 17:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:14 [PATCH v2 net-next 0/9] ethtool mm API consolidation Vladimir Oltean
2023-04-18 11:14 ` [PATCH v2 net-next 1/9] net: enetc: fix MAC Merge layer remaining enabled until a link down event Vladimir Oltean
2023-04-20 14:22 ` Simon Horman
2023-04-20 17:03 ` Vladimir Oltean [this message]
2023-04-21 9:01 ` Simon Horman
2023-04-18 11:14 ` [PATCH v2 net-next 2/9] net: enetc: report mm tx-active based on tx-enabled and verify-status Vladimir Oltean
2023-04-20 14:40 ` Simon Horman
2023-04-18 11:14 ` [PATCH v2 net-next 3/9] net: enetc: only commit preemptible TCs to hardware when MM TX is active Vladimir Oltean
2023-04-20 14:42 ` Simon Horman
2023-04-20 16:34 ` Vladimir Oltean
2023-04-20 16:49 ` Simon Horman
2023-04-18 11:14 ` [PATCH v2 net-next 4/9] net: enetc: include MAC Merge / FP registers in register dump Vladimir Oltean
2023-04-20 14:38 ` Simon Horman
2023-04-20 16:58 ` Vladimir Oltean
2023-04-21 9:03 ` Simon Horman
2023-04-18 11:14 ` [PATCH v2 net-next 5/9] net: ethtool: mm: sanitize some UAPI configurations Vladimir Oltean
2023-04-20 14:43 ` Simon Horman
2023-04-18 11:14 ` [PATCH v2 net-next 6/9] selftests: forwarding: sch_tbf_*: Add a pre-run hook Vladimir Oltean
2023-04-18 11:14 ` [PATCH v2 net-next 7/9] selftests: forwarding: generalize bail_on_lldpad from mlxsw Vladimir Oltean
2023-04-18 11:14 ` [PATCH v2 net-next 8/9] selftests: forwarding: introduce helper for standard ethtool counters Vladimir Oltean
2023-04-18 11:14 ` [PATCH v2 net-next 9/9] selftests: forwarding: add a test for MAC Merge layer Vladimir Oltean
2023-04-21 3:10 ` [PATCH v2 net-next 0/9] ethtool mm API consolidation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420170354.n76b53ws6bitcoj2@skbuf \
--to=vladimir.oltean@nxp$(echo .)com \
--cc=aconole@redhat$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=ferenc.fejes@ericsson$(echo .)com \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=harini.katakam@amd$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=pranavi.somisetty@amd$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=xiaoliang.yang_1@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox