Subject: Re: [PATCH net] qed/qed_sriov: propagate errors from qed_init_run in enable_vf_access

From: Jakub Kicinski <[email-masked]>
Date: Thu, 20 Apr 2023 19:56:55 -0700

On Thu, 20 Apr 2023 11:20:16 +0300 Daniil Tatianin wrote:
> The return value was silently ignored, and not propagated to the caller.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
> 
> Fixes: 1408cc1fa48c ("qed: Introduce VFs")
> Signed-off-by: Daniil Tatianin <[email-masked]>
> ---
> I'm not familiar enough with the code to know if there's anything we
> have to undo here in case qed_init_run returns an error. Any additional
> comments are appreciated.

This patch does not inspire confidence. This is a pretty old driver, 
you need to provide some reasoning why checking the return value is
important, and correct.
-- 
pw-bot: cr