Subject: Re: [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch

From: Philipp Zabel <[email-masked]>
Date: Wed, 26 Apr 2023 09:44:53 +0200

Hi Daniel,

On Tue, Apr 25, 2023 at 05:11:36PM +0100, Daniel Golle wrote:
> On Tue, Apr 25, 2023 at 05:51:37PM +0200, Philipp Zabel wrote:
[...]
> > Please use devm_reset_control_get_exclusive() directly.
> > 
> > > +	if (IS_ERR(priv->rstc)) {
> > > +		dev_err(&pdev->dev, "Couldn't get our reset line\n");
> > > +		return PTR_ERR(priv->rstc);
> > 
> > Not sure if this can actually happen, but there is no need to warn on
> > -EPROBE_DEFER. You could use return dev_err_probe(...) here.
> 
> Thank you for your comments. The series has already been picked to
> net-next. Unless you want to send the suggested changes yourself, I will
> prepare another series with your suggestions, and also apply them to
> mt7530-mdio.c.

That would be great, thank you.

regards
Philipp