Subject: Re: [PATCH v2] net: ipconfig: Allow DNS to be overwritten by DHCPACK

From: Jakub Kicinski <[email-masked]>
Date: Thu, 4 May 2023 09:44:24 -0700

On Thu, 4 May 2023 10:00:04 +0200 Martin Wetterwald wrote:
> +#ifdef IPCONFIG_DHCP
> +            if (ic_nameservers[i] == NONE ||
> +                ic_nameservers_fallback)
> +#else
>              if (ic_nameservers[i] == NONE)
> +#endif

FWIW I'd vote to move the variable out of the #ifdef and avoid the hairy
code, it's just 4 bytes.