From: Jakub Kicinski <kuba@kernel•org>
To: Lorenz Brun <lorenz@brun•one>
Cc: Felix Fietkau <nbd@nbd•name>, John Crispin <john@phrozen•org>,
Sean Wang <sean.wang@mediatek•com>,
Mark Lee <Mark-MC.Lee@mediatek•com>,
Lorenzo Bianconi <lorenzo@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org
Subject: Re: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors
Date: Thu, 11 May 2023 18:06:08 -0700 [thread overview]
Message-ID: <20230511180608.6e1f6620@kernel.org> (raw)
In-Reply-To: <20230510181350.3743141-1-lorenz@brun.one>
On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote:
> for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> ret = clk_prepare_enable(eth->clks[clk]);
> - if (ret)
> + if (ret) {
> + dev_err(eth->dev, "enabling clock %s failed with error %d\n",
> + mtk_clks_source_name[clk], ret);
> goto err_disable_clks;
> + }
dev_err_probe() would be even better, I think?
--
pw-bot: cr
prev parent reply other threads:[~2023-05-12 1:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 18:13 [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors Lorenz Brun
2023-05-12 1:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511180608.6e1f6620@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=lorenz@brun$(echo .)one \
--cc=lorenzo@kernel$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox