public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber•org>
To: Ido Schimmel <idosch@idosch•org>
Cc: Vladimir Nikishkin <vladimir@nikishkin•pw>,
	dsahern@gmail•com, netdev@vger•kernel.org, davem@davemloft•net,
	edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
	eng.alaamohamedsoliman.am@gmail•com, gnault@redhat•com,
	razor@blackwall•org, idosch@nvidia•com, liuhangbin@gmail•com,
	eyal.birger@gmail•com, jtoppins@redhat•com
Subject: Re: [PATCH iproute2-next v5] ip-link: add support for nolocalbypass in vxlan
Date: Sun, 21 May 2023 12:47:41 -0700	[thread overview]
Message-ID: <20230521124741.3bb2904c@hermes.local> (raw)
In-Reply-To: <ZGpvrV4FGjBvqVjg@shredder>

On Sun, 21 May 2023 22:23:25 +0300
Ido Schimmel <idosch@idosch•org> wrote:

> +       if (tb[IFLA_VXLAN_LOCALBYPASS])
> +               print_bool(PRINT_ANY, "localbypass", "localbypass ",
> +                          rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS]))

That will not work for non json case.  It will print localbypass whether it is set or not.
The third argument is a format string used in the print routine.

  reply	other threads:[~2023-05-21 19:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21  5:49 [PATCH iproute2-next v5] ip-link: add support for nolocalbypass in vxlan Vladimir Nikishkin
2023-05-21 19:23 ` Ido Schimmel
2023-05-21 19:47   ` Stephen Hemminger [this message]
2023-05-22  6:15     ` Ido Schimmel
2023-05-22 15:32       ` Stephen Hemminger
2023-05-23  9:31         ` Petr Machata
2023-05-23  9:39         ` Andrea Claudi
2023-05-23  9:52           ` Vladimir Nikishkin
2023-05-23 10:32             ` Andrea Claudi
2023-05-22  6:03   ` Vladimir Nikishkin
2023-05-22  6:22     ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230521124741.3bb2904c@hermes.local \
    --to=stephen@networkplumber$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=dsahern@gmail$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=eng.alaamohamedsoliman.am@gmail$(echo .)com \
    --cc=eyal.birger@gmail$(echo .)com \
    --cc=gnault@redhat$(echo .)com \
    --cc=idosch@idosch$(echo .)org \
    --cc=idosch@nvidia$(echo .)com \
    --cc=jtoppins@redhat$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=liuhangbin@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=razor@blackwall$(echo .)org \
    --cc=vladimir@nikishkin$(echo .)pw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox