From: Jakub Kicinski <kuba@kernel•org>
To: Chris Adams <linux@cmadams•net>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org, Igor Russkikh <irusskikh@marvell•com>,
Egor Pomozov <epomozov@marvell•com>
Subject: Re: netconsole not working on bridge+atlantic
Date: Mon, 22 May 2023 18:37:21 -0700 [thread overview]
Message-ID: <20230522183721.74c395ec@kernel.org> (raw)
In-Reply-To: <20230520030924.GB30096@cmadams.net>
On Fri, 19 May 2023 22:09:24 -0500 Chris Adams wrote:
> Once upon a time, Florian Fainelli <f.fainelli@gmail•com> said:
> > On 5/19/2023 5:38 PM, Chris Adams wrote:
> > >I have a system with an Aquantia AQC107 NIC connected to a bridge (for
> > >VM NICs). I set up netconsole on it, and it logs that it configures
> > >correctly in dmesg, but it doesn't actually send anything (or log any
> > >errors). Any ideas?
> >
> > It does not look like there is a ndo_poll_controller callback
> > implemented by the atlantic driver which is usually a prerequisite
> > to supporting netconsole.
I don't think ndo_poll_controller is strictly necessary any more.
If absent core will poll all NAPI instances of the driver with budget
of 0.
> Is that something that netconsole (or anything else in the kernel) could
> check and warn about? Is there a way other than looking at the source
> (and knowing what to look for) to tell which NICs do or don't support
> netconsole? I searched around and didn't see that netconsole is only
> expected to work with some NICs, or has certain requirements for
> working.
>
> > >This is on Fedora 37, updated to distro kernel 6.3.3-100.fc37.x86_64.
> > >It hasn't worked for some time (not sure exactly when).
> >
> > Does that mean that it worked up to a certain point and then stopped?
>
> I'm not sure, I didn't check it for a while (I only use it when
> something isn't working right, and that doesn't happen much). It's
> possible it hasn't worked since I added the Aquantia NIC.
You can try to use the kfree_skb tracepoint to see where the netcons
skbs get dropped.
prev parent reply other threads:[~2023-05-23 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 0:38 netconsole not working on bridge+atlantic Chris Adams
2023-05-20 2:52 ` Florian Fainelli
2023-05-20 3:09 ` Chris Adams
2023-05-23 1:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522183721.74c395ec@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=epomozov@marvell$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=irusskikh@marvell$(echo .)com \
--cc=linux@cmadams$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox