Subject: Re: [PATCH net v2] tcp: Return user_mss for TCP_MAXSEG in CLOSE/LISTEN state if user_mss set

From: Jakub Kicinski <[email-masked]>
Date: Fri, 26 May 2023 19:41:36 -0700

On Wed, 24 May 2023 21:13:31 +0800 Cambda Zhu wrote:
> This patch replaces the tp->mss_cache check in getting TCP_MAXSEG
> with tp->rx_opt.user_mss check for CLOSE/LISTEN sock. Since
> tp->mss_cache is initialized with TCP_MSS_DEFAULT, checking if
> it's zero is probably a bug.
> 
> With this change, getting TCP_MAXSEG before connecting will return
> default MSS normally, and return user_mss if user_mss is set.

Hi, your patch was marked as "Changes requested" by DaveM (I think).
Presumably because of the missing CCs. Would you mind resending one
more time with the fuller CC list?