From: Jakub Kicinski <kuba@kernel•org>
To: Justin Chen <justin.chen@broadcom•com>
Cc: netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
bcm-kernel-feedback-list@broadcom•com,
florian.fainelli@broadcom•com, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com, robh+dt@kernel•org,
krzysztof.kozlowski+dt@linaro•org, conor+dt@kernel•org,
opendmb@gmail•com, andrew@lunn•ch, hkallweit1@gmail•com,
linux@armlinux•org.uk, richardcochran@gmail•com,
sumit.semwal@linaro•org, christian.koenig@amd•com,
simon.horman@corigine•com
Subject: Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Date: Fri, 2 Jun 2023 23:52:54 -0700 [thread overview]
Message-ID: <20230602235254.61798d80@kernel.org> (raw)
In-Reply-To: <1685657551-38291-4-git-send-email-justin.chen@broadcom.com>
On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote:
> + ports_node = of_find_node_by_name(dev->of_node, "ethernet-ports");
> + if (!ports_node) {
> + dev_warn(dev, "No ports found\n");
> + return 0;
> + }
> +
> + for_each_available_child_of_node(ports_node, intf_node) {
> + of_property_read_u32(intf_node, "reg", &port);
> + if (!bcmasp_is_port_valid(priv, port)) {
> + dev_warn(dev, "%pOF: %d is an invalid port\n",
> + intf_node, port);
> + continue;
> + }
> +
> + priv->intf_count++;
> + }
I think that you're leaking ports_node,
/**
* of_find_node_by_name - Find a node by its "name" property
* @from: The node to start searching from or NULL; the node
* you pass will not be searched, only the next one
* will. Typically, you pass what the previous call
* returned. of_node_put() will be called on @from.
* @name: The name string to match against
*
* Return: A node pointer with refcount incremented, use
* of_node_put() on it when done.
*/
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-03 6:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 22:12 [PATCH net-next v6 0/6] Brcm ASP 2.0 Ethernet Controller Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Justin Chen
2023-06-07 22:24 ` Rob Herring
2023-06-01 22:12 ` [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 " Justin Chen
2023-06-03 6:52 ` Jakub Kicinski [this message]
2023-06-03 6:58 ` Jakub Kicinski
2023-06-05 22:04 ` Florian Fainelli
2023-06-06 22:58 ` Justin Chen
2023-06-07 0:16 ` Jakub Kicinski
2023-06-07 1:35 ` Justin Chen
2023-06-07 1:54 ` Jakub Kicinski
2023-06-07 2:33 ` Justin Chen
2023-06-07 3:45 ` Jakub Kicinski
2023-06-07 4:22 ` Justin Chen
2023-06-07 4:35 ` Jakub Kicinski
2023-06-01 22:12 ` [PATCH net-next v6 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602235254.61798d80@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=justin.chen@broadcom$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opendmb@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=simon.horman@corigine$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox