Subject: Re: [PATCH v2] ARM: dts: vf610: ZII: Add missing phy-mode and fixed links

From: Shawn Guo <[email-masked]>
Date: Sun, 4 Jun 2023 20:07:48 +0800

On Mon, May 29, 2023 at 04:35:07PM +0300, Vladimir Oltean wrote:
> On Thu, May 25, 2023 at 08:26:06PM +0200, Andrew Lunn wrote:
> > diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > index 96495d965163..1a19aec8957b 100644
> > --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > @@ -202,7 +202,7 @@ port@5 {
> >  
> >  				port@6 {
> >  					reg = <6>;
> > -					label = "cpu";
> > +					phy-mode = "rmii";
> >  					ethernet = <&fec1>;
> >  
> >  					fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > index 6280c5e86a12..6071eb6b33a0 100644
> > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > @@ -75,7 +75,7 @@ fixed-link {
> >  
> >  					port@6 {
> >  						reg = <6>;
> > -						label = "cpu";
> > +						phy-mode = "rmii";
> >  						ethernet = <&fec1>;
> >  
> >  						fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > index c00d39562a10..6f9878f124c4 100644
> > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > @@ -44,7 +44,7 @@ ports {
> >  
> >  					port@0 {
> >  						reg = <0>;
> > -						label = "cpu";
> > +						phy-mode = "rmii";
> >  						ethernet = <&fec1>;
> >  
> >  						fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > index 7b3276cd470f..df1335492a19 100644
> > --- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > @@ -59,7 +59,7 @@ ports {
> >  
> >  					port@0 {
> >  						reg = <0>;
> > -						label = "cpu";
> > +						phy-mode = "rmii";
> >  						ethernet = <&fec1>;
> >  
> >  						fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> > index 180acb0795b9..1461804ecaea 100644
> > --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> > @@ -140,7 +140,7 @@ ports {
> >  
> >  				port@0 {
> >  					reg = <0>;
> > -					label = "cpu";
> > +					phy-mode = "rmii";
> >  					ethernet = <&fec1>;
> >  
> >  					fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > index 73fdace4cb42..463c2452b9b7 100644
> > --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > @@ -129,7 +129,7 @@ ports {
> >  
> >  				port@0 {
> >  					reg = <0>;
> > -					label = "cpu";
> > +					phy-mode = "rmii";
> >  					ethernet = <&fec1>;
> >  
> >  					fixed-link {
> > diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > index 20beaa8433b6..f5ae0d5de315 100644
> > --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > @@ -154,7 +154,7 @@ ports {
> >  
> >  				port@0 {
> >  					reg = <0>;
> > -					label = "cpu";
> > +					phy-mode = "rmii";
> >  					ethernet = <&fec1>;
> >  
> >  					fixed-link {
> 
> Shouldn't these have been rev-rmii to be consistent with what was done
> for arm64?

Should I drop the patch for now, or can this be changed incrementally if
needed?

Shawn