Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash

From: Jakub Kicinski <[email-masked]>
Date: Mon, 5 Jun 2023 15:52:53 -0700

On Fri,  2 Jun 2023 16:31:40 +0000 Eric Dumazet wrote:
> +		if (sk->sk_state == TCP_ESTABLISHED) {
> +			/* This READ_ONCE() is paired with the WRITE_ONCE()
> +			 * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> +			 */
> +			sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> +			}

Hi Eric, the series got "changes requested", a bit unclear why, 
I'm guessing it's because it lacks Fixes tags.

I also noticed that the closing bracket above looks misaligned.

Would you mind reposting? If you prefer not to add Fixes tag
a mention that it's intentional in the cover letter is enough.