Subject: Re: [PATCH net-next] ethtool: ioctl: improve error checking for set_wol

From: Jakub Kicinski <[email-masked]>
Date: Tue, 6 Jun 2023 20:54:37 -0700

On Mon,  5 Jun 2023 11:46:16 -0700 Justin Chen wrote:
> +	if (wol.wolopts & ~cur_wol.supported)
> +		return -EOPNOTSUPP;

One small comment - I think we should return -EINVAL here.
That's what netlink return and we seem to mostly return -EOPNOTSUPP
if the operation is completely not supported.
-- 
pw-bot: cr