Subject: Re: [PATCH net-next 05/15] idpf: add create vport and netdev configuration

From: Jakub Kicinski <[email-masked]>
Date: Wed, 7 Jun 2023 12:10:06 -0700

On Wed, 7 Jun 2023 20:20:57 +0200 Willem de Bruijn wrote:
> > > Please use locks. Every single Intel driver comes with gazillion flags
> > > and endless bugs when the flags go out of sync.  
> >
> > Thanks for the feedback. Will use mutex lock instead of 'VC_MSG_PENDING'
> > flag.  
> 
> Was that the intent of the comment?
> 
> Or is it to replace these individual atomic test_and_set bit
> operations with a single spinlock-protected critical section around
> all the flag operations?

No, no. Intel drivers have a history of adding flags to work around
locking problems. Whatever this bit is protecting should be protected
by a normal synchronization primitive instead.

I don't understand why.

Replacing an atomic bitop with a spin lock is a non-change.

> That's how I read the suggestion.