public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel•org>
To: Joyce Ooi <joyce.ooi@intel•com>,
	"David S. Miller" <davem@davemloft•net>,
	Eric Dumazet <edumazet@google•com>,
	Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
	Maxime Chevallier <maxime.chevallier@bootlin•com>,
	Simon Horman <simon.horman@corigine•com>
Cc: Arnd Bergmann <arnd@arndb•de>,
	netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: [PATCH 2/2] net: altera-tse: fix broken Kconfig dependency
Date: Wed,  7 Jun 2023 15:56:33 +0200	[thread overview]
Message-ID: <20230607135638.1341101-2-arnd@kernel.org> (raw)
In-Reply-To: <20230607135638.1341101-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb•de>

The CONFIG_PCS_ALTERA_TSE symbol is gone, so make sure the ethernet
driver selects the correct symbol for its replacement, avoiding:

x86_64-linux-ld: drivers/net/ethernet/altera/altera_tse_main.o: in function `altera_tse_remove':
altera_tse_main.c:(.text+0xdf): undefined reference to `lynx_pcs_destroy'

Fixes: 196eec4062b00 ("net: pcs: Drop the TSE PCS driver")
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
 drivers/net/ethernet/altera/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig
index 93533ba034294..17985319088c1 100644
--- a/drivers/net/ethernet/altera/Kconfig
+++ b/drivers/net/ethernet/altera/Kconfig
@@ -4,7 +4,7 @@ config ALTERA_TSE
 	depends on HAS_DMA
 	select PHYLIB
 	select PHYLINK
-	select PCS_ALTERA_TSE
+	select PCS_LYNX
 	select MDIO_REGMAP
 	select REGMAP_MMIO
 	help
-- 
2.39.2


  reply	other threads:[~2023-06-07 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 13:56 [PATCH 1/2] stmmac: fix pcs_lynx link failure Arnd Bergmann
2023-06-07 13:56 ` Arnd Bergmann [this message]
2023-06-07 14:12 ` Russell King (Oracle)
2023-06-07 15:52   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607135638.1341101-2-arnd@kernel.org \
    --to=arnd@kernel$(echo .)org \
    --cc=arnd@arndb$(echo .)de \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=joyce.ooi@intel$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=maxime.chevallier@bootlin$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=simon.horman@corigine$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox