From: Jakub Kicinski <kuba@kernel•org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel•com>
Cc: jiri@resnulli•us, vadfed@meta•com, jonathan.lemon@gmail•com,
pabeni@redhat•com, corbet@lwn•net, davem@davemloft•net,
edumazet@google•com, vadfed@fb•com, jesse.brandeburg@intel•com,
anthony.l.nguyen@intel•com, saeedm@nvidia•com, leon@kernel•org,
richardcochran@gmail•com, sj@kernel•org, javierm@redhat•com,
ricardo.canuelo@collabora•com, mst@redhat•com,
tzimmermann@suse•de, michal.michalik@intel•com,
gregkh@linuxfoundation•org, jacek.lawrynowicz@linux•intel.com,
airlied@redhat•com, ogabbay@kernel•org, arnd@arndb•de,
nipun.gupta@amd•com, axboe@kernel•dk, linux@zary•sk,
masahiroy@kernel•org, benjamin.tissoires@redhat•com,
geert+renesas@glider•be, milena.olech@intel•com,
kuniyu@amazon•com, liuhangbin@gmail•com, hkallweit1@gmail•com,
andy.ren@getcruise•com, razor@blackwall•org, idosch@nvidia•com,
lucien.xin@gmail•com, nicolas.dichtel@6wind•com, phil@nwl•cc,
claudiajkang@gmail•com, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, linux-rdma@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, poros@redhat•com,
mschmidt@redhat•com, linux-clk@vger•kernel.org,
vadim.fedorenko@linux•dev
Subject: Re: [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem interface
Date: Mon, 12 Jun 2023 15:43:29 -0700 [thread overview]
Message-ID: <20230612154329.7bd2d52f@kernel.org> (raw)
In-Reply-To: <20230609121853.3607724-2-arkadiusz.kubalewski@intel.com>
On Fri, 9 Jun 2023 14:18:44 +0200 Arkadiusz Kubalewski wrote:
> From: Vadim Fedorenko <vadim.fedorenko@linux•dev>
>
> Add documentation explaining common netlink interface to configure DPLL
> devices and monitoring events. Common way to implement DPLL device in
> a driver is also covered.
> +``'pin': [{
> + {'clock-id': 282574471561216,
> + 'module-name': 'ice',
> + 'pin-dpll-caps': 4,
> + 'pin-id': 13,
> + 'pin-parent': [{'pin-id': 2, 'pin-state': 'connected'},
> + {'pin-id': 3, 'pin-state': 'disconnected'},
> + {'id': 0, 'pin-direction': 'input'},
> + {'id': 1, 'pin-direction': 'input'}],
> + 'pin-type': 'synce-eth-port'}
> +}]``
It seems like pin-parent is overloaded, can we split it into two
different nests?
> +SET commands format
> +===================
> +
> +``DPLL_CMD_DEVICE_SET`` - to target a dpll device, the user provides
> +``DPLL_A_ID``, which is unique identifier of dpll device in the system,
> +as well as parameter being configured (``DPLL_A_MODE``).
> +
> +``DPLL_CMD_PIN_SET`` - to target a pin user has to provide a
> +``DPLL_A_PIN_ID``, which is unique identifier of a pin in the system.
> +Also configured pin parameters must be added.
> +If ``DPLL_A_PIN_DIRECTION`` or ``DPLL_A_PIN_FREQUENCY`` are configured,
> +this affects all the dpll device they are connected, that is why those
> +attributes shall not be enclosed in ``DPLL_A_PIN_PARENT``.
> +Other attributes:
> +``DPLL_A_PIN_PRIO`` or ``DPLL_A_PIN_STATE`` must be enclosed in
> +``DPLL_A_PIN_PARENT`` as their configuration relates to only one
> +parent dpll or parent pin.
Also sounds like setting pin attrs and pin-parent attrs should be
different commands.
next prev parent reply other threads:[~2023-06-12 22:43 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:18 [RFC PATCH v8 00/10] Create common DPLL configuration API Arkadiusz Kubalewski
2023-06-09 12:18 ` [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem interface Arkadiusz Kubalewski
2023-06-10 3:22 ` Bagas Sanjaya
2023-06-12 14:24 ` Kubalewski, Arkadiusz
2023-06-10 16:28 ` Jiri Pirko
2023-06-12 15:24 ` Kubalewski, Arkadiusz
2023-06-12 22:30 ` Jakub Kicinski
2023-06-12 15:30 ` Bart Van Assche
2023-06-12 16:01 ` Kubalewski, Arkadiusz
2023-06-12 22:43 ` Jakub Kicinski [this message]
2023-06-13 9:55 ` Jiri Pirko
2023-06-13 16:38 ` Jakub Kicinski
2023-06-14 9:27 ` Jiri Pirko
2023-06-14 12:21 ` Kubalewski, Arkadiusz
2023-06-14 19:15 ` Jakub Kicinski
2023-06-14 19:23 ` Jakub Kicinski
2023-06-15 10:18 ` Jiri Pirko
2023-06-15 13:44 ` Kubalewski, Arkadiusz
2023-06-15 16:31 ` Jakub Kicinski
2023-06-17 10:36 ` Jiri Pirko
2023-06-12 23:49 ` Jakub Kicinski
2023-06-14 12:23 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [RFC PATCH v8 02/10] dpll: spec: Add Netlink spec in YAML Arkadiusz Kubalewski
2023-06-10 16:22 ` Jiri Pirko
2023-06-15 13:42 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions Arkadiusz Kubalewski
2023-06-10 17:38 ` Jiri Pirko
2023-06-21 16:28 ` Kubalewski, Arkadiusz
2023-06-21 18:55 ` Kubalewski, Arkadiusz
2023-06-22 7:05 ` Jiri Pirko
2023-07-17 19:03 ` Vadim Fedorenko
2023-06-11 9:36 ` Jiri Pirko
2023-06-12 7:25 ` Paolo Abeni
2023-06-21 20:38 ` Kubalewski, Arkadiusz
2023-06-11 10:01 ` Jiri Pirko
2023-06-12 23:45 ` Jakub Kicinski
2023-06-21 21:17 ` Kubalewski, Arkadiusz
2023-06-22 7:09 ` Jiri Pirko
2023-06-09 12:18 ` [RFC PATCH v8 04/10] dpll: netlink: " Arkadiusz Kubalewski
2023-06-11 11:42 ` Jiri Pirko
2023-06-23 1:01 ` Kubalewski, Arkadiusz
2023-06-21 11:18 ` Petr Oros
2023-06-21 11:53 ` Jiri Pirko
2023-06-21 13:07 ` Jiri Pirko
2023-06-23 0:56 ` Kubalewski, Arkadiusz
2023-06-23 7:48 ` Jiri Pirko
2023-06-23 0:56 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [RFC PATCH v8 05/10] dpll: api header: " Arkadiusz Kubalewski
2023-06-10 7:25 ` Jiri Pirko
2023-06-10 7:29 ` Jiri Pirko
2023-06-12 15:00 ` Vadim Fedorenko
2023-06-10 7:32 ` Jiri Pirko
2023-06-09 12:18 ` [RFC PATCH v8 06/10] netdev: expose DPLL pin handle for netdevice Arkadiusz Kubalewski
2023-06-12 9:17 ` Petr Oros
2023-06-13 13:51 ` Jiri Pirko
2023-06-14 12:25 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [RFC PATCH v8 07/10] ice: add admin commands to access cgu configuration Arkadiusz Kubalewski
2023-06-10 8:46 ` Jiri Pirko
2023-06-15 21:35 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu Arkadiusz Kubalewski
2023-06-10 9:57 ` Jiri Pirko
2023-06-19 18:08 ` Kubalewski, Arkadiusz
2023-06-21 12:28 ` Jiri Pirko
2023-06-10 16:36 ` Jiri Pirko
2023-06-19 20:34 ` Kubalewski, Arkadiusz
2023-06-21 12:29 ` Jiri Pirko
2023-06-29 6:14 ` Jiri Pirko
2023-07-03 12:37 ` Kubalewski, Arkadiusz
2023-07-10 8:23 ` Jiri Pirko
2023-06-09 12:18 ` [RFC PATCH v8 09/10] ptp_ocp: implement DPLL ops Arkadiusz Kubalewski
2023-06-10 8:06 ` Jiri Pirko
2023-06-09 12:18 ` [RFC PATCH v8 10/10] mlx5: Implement SyncE support using DPLL infrastructure Arkadiusz Kubalewski
2023-06-09 23:27 ` [RFC PATCH v8 00/10] Create common DPLL configuration API Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612154329.7bd2d52f@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=airlied@redhat$(echo .)com \
--cc=andy.ren@getcruise$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=axboe@kernel$(echo .)dk \
--cc=benjamin.tissoires@redhat$(echo .)com \
--cc=claudiajkang@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkallweit1@gmail$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacek.lawrynowicz@linux$(echo .)intel.com \
--cc=javierm@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuniyu@amazon$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux@zary$(echo .)sk \
--cc=liuhangbin@gmail$(echo .)com \
--cc=lucien.xin@gmail$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=michal.michalik@intel$(echo .)com \
--cc=milena.olech@intel$(echo .)com \
--cc=mschmidt@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=nipun.gupta@amd$(echo .)com \
--cc=ogabbay@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=phil@nwl$(echo .)cc \
--cc=poros@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=ricardo.canuelo@collabora$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sj@kernel$(echo .)org \
--cc=tzimmermann@suse$(echo .)de \
--cc=vadfed@fb$(echo .)com \
--cc=vadfed@meta$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox