Subject: Re: [PATCH net-next] gro: move the tc_ext comparison to a helper

From: Jakub Kicinski <[email-masked]>
Date: Wed, 14 Jun 2023 10:55:16 -0700

On Wed, 14 Jun 2023 20:58:53 +0800 Yunsheng Lin wrote:
> > +static void gro_list_prepare_tc_ext(const struct sk_buff *skb,
> > +				    const struct sk_buff *p,
> > +				    unsigned long *diffs)  
> 
> Isn't it more common to do something like below?
> 
> static unsigned long gro_list_prepare_tc_ext(const struct sk_buff *skb,
> 					     const struct sk_buff *p,
> 					     unsigned long diffs)
> 
> Is it because the resulting machine code is bigger for the above
> case?

Not really, just laziness - the above is more typing.
I guess avoiding output args is worth while, so between this and
Simon's comment - let me respin.
-- 
pw-bot: cr