Subject: Re: [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration

From: Stephen Hemminger <[email-masked]>
Date: Wed, 14 Jun 2023 11:21:44 -0700

On Wed, 14 Jun 2023 10:14:18 -0700
Tony Nguyen <[email-masked]> wrote:

> +	/* TX */
> +	int num_txq;
> +	int num_complq;
> +	/* It makes more sense for descriptor count to be part of only idpf
> +	 * queue structure. But when user changes the count via ethtool, driver
> +	 * has to store that value somewhere other than queue structure as the
> +	 * queues will be freed and allocated again.
> +	 */
> +	int txq_desc_count;
> +	int complq_desc_count;
> +	int num_txq_grp;
> +	u32 txq_model;
> +
> +	/* RX */
> +	int num_rxq;
> +	int num_bufq;
> +	int rxq_desc_count;

If value can never be negative, you can avoid future errors by using
an unsigned type. Ideally to save space use u32 or u16.