From: Arnd Bergmann <arnd@kernel•org>
To: Edward Cree <ecree.xilinx@gmail•com>,
Martin Habets <habetsm.xilinx@gmail•com>,
Jakub Kicinski <kuba@kernel•org>
Cc: Arnd Bergmann <arnd@arndb•de>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Alejandro Lucero <alejandro.lucero-palau@amd•com>,
Jiri Pirko <jiri@resnulli•us>,
Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd•com>,
Simon Horman <simon.horman@corigine•com>,
netdev@vger•kernel.org, linux-net-drivers@amd•com,
linux-kernel@vger•kernel.org
Subject: [PATCH 2/2] sfc: add CONFIG_INET dependency for TC offload
Date: Fri, 16 Jun 2023 11:08:19 +0200 [thread overview]
Message-ID: <20230616090844.2677815-2-arnd@kernel.org> (raw)
In-Reply-To: <20230616090844.2677815-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb•de>
The driver now fails to link when CONFIG_INET is disabled, so
add an explicit Kconfig dependency:
ld.lld: error: undefined symbol: ip_route_output_flow
>>> referenced by tc_encap_actions.c
>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_flower_create_encap_md) in archive vmlinux.a
ld.lld: error: undefined symbol: ip_send_check
>>> referenced by tc_encap_actions.c
>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a
>>> referenced by tc_encap_actions.c
>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a
ld.lld: error: undefined symbol: arp_tbl
>>> referenced by tc_encap_actions.c
>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a
>>> referenced by tc_encap_actions.c
>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a
Fixes: a1e82162af0b8 ("sfc: generate encap headers for TC offload")
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
drivers/net/ethernet/sfc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
index 4af36ba8906ba..3eb55dcfa8a61 100644
--- a/drivers/net/ethernet/sfc/Kconfig
+++ b/drivers/net/ethernet/sfc/Kconfig
@@ -50,6 +50,7 @@ config SFC_MCDI_MON
config SFC_SRIOV
bool "Solarflare SFC9100-family SR-IOV support"
depends on SFC && PCI_IOV
+ depends on INET
default y
help
This enables support for the Single Root I/O Virtualization
--
2.39.2
next prev parent reply other threads:[~2023-06-16 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:08 [PATCH 1/2] sfc: fix uninitialized variable use Arnd Bergmann
2023-06-16 9:08 ` Arnd Bergmann [this message]
2023-06-16 10:06 ` [PATCH 2/2] sfc: add CONFIG_INET dependency for TC offload Simon Horman
2023-06-16 11:39 ` Edward Cree
2023-06-16 13:45 ` Thorsten Leemhuis
2023-06-16 10:06 ` [PATCH 1/2] sfc: fix uninitialized variable use Simon Horman
2023-06-16 11:29 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616090844.2677815-2-arnd@kernel.org \
--to=arnd@kernel$(echo .)org \
--cc=alejandro.lucero-palau@amd$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pieter.jansen-van-vuuren@amd$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox