Subject: Re: [PATCH net-next v2 04/15] idpf: add core init and interrupt request

From: Jakub Kicinski <[email-masked]>
Date: Fri, 16 Jun 2023 23:50:41 -0700

On Wed, 14 Jun 2023 10:14:17 -0700 Tony Nguyen wrote:
> + * @IDPF_REL_RES_IN_PROG: Resources release in progress

> + * @IDPF_CANCEL_SERVICE_TASK: Do not schedule service task if bit is set
> + * @IDPF_REMOVE_IN_PROG: Driver remove in progress

Why all the X-in-progress flags, again?

> +	set_bit(IDPF_CANCEL_SERVICE_TASK, adapter->flags);
> +	cancel_delayed_work_sync(&adapter->serv_task);
> +	clear_bit(IDPF_CANCEL_SERVICE_TASK, adapter->flags);

Pretty sure workqueue protects from self-requeueing.