From: Christian Marangi <ansuelsmth@gmail•com>
To: Pavel Machek <pavel@ucw•cz>, Lee Jones <lee@kernel•org>,
Christian Marangi <ansuelsmth@gmail•com>,
Andrew Lunn <andrew@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Yang Li <yang.lee@linux•alibaba.com>,
linux-leds@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org
Subject: [net-next PATCH v4 3/3] leds: trigger: netdev: expose hw_control status via sysfs
Date: Sat, 17 Jun 2023 13:53:55 +0200 [thread overview]
Message-ID: <20230617115355.22868-4-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20230617115355.22868-1-ansuelsmth@gmail.com>
Expose hw_control status via sysfs for the netdev trigger to give
userspace better understanding of the current state of the trigger and
the LED.
Signed-off-by: Christian Marangi <ansuelsmth@gmail•com>
---
drivers/leds/trigger/ledtrig-netdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index 90b682d49998..a550a1895642 100644
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -406,6 +406,16 @@ static ssize_t interval_store(struct device *dev,
static DEVICE_ATTR_RW(interval);
+static ssize_t hw_control_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
+
+ return sprintf(buf, "%d\n", trigger_data->hw_control);
+}
+
+static DEVICE_ATTR_RO(hw_control);
+
static struct attribute *netdev_trig_attrs[] = {
&dev_attr_device_name.attr,
&dev_attr_link.attr,
@@ -417,6 +427,7 @@ static struct attribute *netdev_trig_attrs[] = {
&dev_attr_rx.attr,
&dev_attr_tx.attr,
&dev_attr_interval.attr,
+ &dev_attr_hw_control.attr,
NULL
};
ATTRIBUTE_GROUPS(netdev_trig);
--
2.40.1
next prev parent reply other threads:[~2023-06-18 19:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 11:53 [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes Christian Marangi
2023-06-17 11:53 ` [net-next PATCH v4 1/3] leds: trigger: netdev: add additional specific link speed mode Christian Marangi
2023-06-17 11:53 ` [net-next PATCH v4 2/3] leds: trigger: netdev: add additional specific link duplex mode Christian Marangi
2023-06-18 20:10 ` Andrew Lunn
2023-06-17 11:53 ` Christian Marangi [this message]
2023-06-18 20:15 ` [net-next PATCH v4 3/3] leds: trigger: netdev: expose hw_control status via sysfs Andrew Lunn
2023-06-19 10:40 ` [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes Lee Jones
2023-06-19 13:34 ` Andrew Lunn
2023-06-20 10:26 ` Lee Jones
2023-06-20 13:59 ` Andrew Lunn
2023-06-21 14:56 ` Lee Jones
2023-06-19 20:27 ` Simon Horman
2023-06-19 20:48 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230617115355.22868-4-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=lee@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
--cc=yang.lee@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox